Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nuspec project target frameworks for source-build #3285

Merged
merged 11 commits into from
Mar 9, 2022

Conversation

lbussell
Copy link
Contributor

I'm taking over #3188 from @MichaelSimons. I'm opening this as a draft PR to get CI running.

Description

This change should remove prebuilts caused from targeting netcoreapp1.0.

Related issue

dotnet/source-build#2708

This patch removes prebuilts caused from targetting netcoreapp1.0

Backported with microsoft#3188
@Haplois Haplois force-pushed the apply-source-build-patch branch from 4929b0c to dd1928a Compare January 31, 2022 23:22
@lbussell
Copy link
Contributor Author

Hi @Haplois - I didn't mean to make the source-build patch fail with cd51688, if that's why you removed the patch. I was just experimenting and didn't realize at the time that this repo also carries its own patches for that file. We still might need the patch, I'm not sure.

@Haplois
Copy link
Contributor

Haplois commented Feb 1, 2022

@lbussell, I basically included the patch in the repository - it was unnecessary.

@Haplois Haplois force-pushed the apply-source-build-patch branch from 9988689 to 25cce3b Compare February 1, 2022 00:37
@Haplois Haplois force-pushed the apply-source-build-patch branch from 7d60db3 to 61d250e Compare February 1, 2022 01:02
@lbussell
Copy link
Contributor Author

lbussell commented Mar 5, 2022

I have verified that the current set of changes work in the end-to-end source build and that no new prebuilts are introduced.

@lbussell lbussell marked this pull request as ready for review March 5, 2022 00:03
@Haplois Haplois merged commit d79ba05 into microsoft:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants